Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757885Ab2HUQEy (ORCPT ); Tue, 21 Aug 2012 12:04:54 -0400 Received: from relay.parallels.com ([195.214.232.42]:52428 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757864Ab2HUQEt convert rfc822-to-8bit (ORCPT ); Tue, 21 Aug 2012 12:04:49 -0400 Message-ID: <5033B199.6080305@parallels.com> Date: Tue, 21 Aug 2012 20:04:41 +0400 From: Stanislav Kinsbursky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: David Miller CC: "dhowells@redhat.com" , "netdev@vger.kernel.org" , "rick.jones2@hp.com" , "ycheng@google.com" , "linux-kernel@vger.kernel.org" , Subject: Re: [PATCH] tun: don't zeroize sock->file on detach References: <20120809124436.5156.26944.stgit@localhost.localdomain> <20120809.161639.1789560369123168415.davem@davemloft.net> In-Reply-To: <20120809.161639.1789560369123168415.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1536 Lines: 44 10.08.2012 03:16, David Miller пишет: > From: Stanislav Kinsbursky > Date: Thu, 09 Aug 2012 16:50:40 +0400 > >> This is a fix for bug, introduced in 3.4 kernel by commit >> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced >> simple sock_put() by sk_release_kernel(). Below is sequence, which leads to >> oops for non-persistent devices: >> >> tun_chr_close() >> tun_detach() <== tun->socket.file = NULL >> tun_free_netdev() >> sk_release_sock() >> sock_release(sock->file == NULL) >> iput(SOCK_INODE(sock)) <== dereference on NULL pointer >> >> This patch just removes zeroing of socket's file from __tun_detach(). >> sock_release() will do this. >> >> Cc: stable@vger.kernel.org >> Reported-by: Ruan Zhijie >> Tested-by: Ruan Zhijie >> Acked-by: Al Viro >> Acked-by: Eric Dumazet >> Acked-by: Yuchung Cheng >> Signed-off-by: Stanislav Kinsbursky > > Applied, thanks. > Hi, David. I found out, that this commit: b09e786bd1dd66418b69348cb110f3a64764626a was previous attempt to fix the problem. I believe this commit have to be dropped. -- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/