Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044Ab2HVIjW (ORCPT ); Wed, 22 Aug 2012 04:39:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126Ab2HVIjQ (ORCPT ); Wed, 22 Aug 2012 04:39:16 -0400 Date: Wed, 22 Aug 2012 10:38:12 +0200 From: Jiri Olsa To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Andi Kleen , Ben Hutchings , Borislav Petkov , Corey Ashford , David Ahern , Feng Tang , Frederic Weisbecker , Mike Galbraith , Namhyung Kim , Namhyung Kim , Namhyung Kim , Paul Mackerras , Pekka Enberg , Peter Zijlstra , Robert Richter , Sedat Dilek , Stephane Eranian , Steven Rostedt , Thomas Gleixner , Ulrich Drepper , arnaldo.melo@gmail.com, Arnaldo Carvalho de Melo Subject: [PATCH] perf tools: Fix 'No libunwind found' make warning message Message-ID: <20120822083812.GC1003@krava.brq.redhat.com> References: <1345479985-18669-1-git-send-email-acme@infradead.org> <20120821093231.GA12385@gmail.com> <20120821093628.GA981@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120821093628.GA981@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1877 Lines: 58 On Tue, Aug 21, 2012 at 11:36:28AM +0200, Jiri Olsa wrote: > On Tue, Aug 21, 2012 at 11:32:31AM +0200, Ingo Molnar wrote: > > > > * Arnaldo Carvalho de Melo wrote: > > > > SNIP > > > > > One minor observation, the Makefile tells us: > > > > Makefile:496: No libunwind found. Please install libunwind >= 0.99 > > > > I guess that should be libunwind-dev[el], right? Plain libunwind > > is not enough. > > right, will fix it > > thanks, > jirka --- Changing error message when libunwind support is not found to inform properly to install libunwind-dev[el] package. Reported-by: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Signed-off-by: Jiri Olsa --- tools/perf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 6bd888d..218cdb5 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -493,7 +493,7 @@ endif FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(ALL_CFLAGS) $(LIBUNWIND_LDFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS) ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y) - msg := $(warning No libunwind found. Please install libunwind >= 0.99); + msg := $(warning No libunwind found, disables post unwind support. Please install libunwind-dev[el] >= 0.99); NO_LIBUNWIND := 1 endif # Libunwind support endif # NO_LIBUNWIND -- 1.7.11.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/