Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756046Ab2HVP7P (ORCPT ); Wed, 22 Aug 2012 11:59:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8932 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739Ab2HVP7L (ORCPT ); Wed, 22 Aug 2012 11:59:11 -0400 Date: Wed, 22 Aug 2012 17:55:21 +0200 From: Oleg Nesterov To: Ananth N Mavinakayanahalli Cc: ppcdev , lkml , benh@kernel.crashing.org, Paul Mackerras , Anton Blanchard , peterz@infradead.org, Srikar Dronamraju , Ingo Molnar , michael@ellerman.id.au Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc Message-ID: <20120822155521.GA3993@redhat.com> References: <20120822082205.GA29216@in.ibm.com> <20120822082708.GB29216@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120822082708.GB29216@in.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 25 On 08/22, Ananth N Mavinakayanahalli wrote: > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long addr) > +{ > + unsigned int insn; > + > + if (addr & 0x03) > + return -EINVAL; > + > + memcpy(&insn, auprobe->insn, MAX_UINSN_BYTES); > + if (is_trap(insn)) > + return -ENOTSUPP; This addresses the only concern I had, thanks. Once again, I am in no position to review the powerpc code, but since I made some noise before: I think the patch is fine. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/