Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474Ab2HVRuR (ORCPT ); Wed, 22 Aug 2012 13:50:17 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:41313 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754099Ab2HVRuN (ORCPT ); Wed, 22 Aug 2012 13:50:13 -0400 Date: Wed, 22 Aug 2012 18:49:45 +0100 From: Will Deacon To: Stephen Boyd Cc: Arnd Bergmann , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Shinya Kuribayashi Subject: Re: [PATCH 1/4] ARM: export read_current_timer Message-ID: <20120822174945.GS9093@mudshark.cambridge.arm.com> References: <1345645780-2749-1-git-send-email-arnd@arndb.de> <1345645780-2749-2-git-send-email-arnd@arndb.de> <503513A2.1030002@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <503513A2.1030002@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 33 On Wed, Aug 22, 2012 at 06:15:14PM +0100, Stephen Boyd wrote: > On 08/22/12 07:29, Arnd Bergmann wrote: > > read_current_timer is used in the get_cycles() function when > > ARM_ARCH_TIMER is set, and that function can be inlined into > > driver modules, so we should export the function to avoid > > errors like > > > > ERROR: "read_current_timer" [drivers/video/udlfb.ko] undefined! > > ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined! > > > > Signed-off-by: Arnd Bergmann > > Cc: Shinya Kuribayashi > > Acked-by: Stephen Boyd > > I ran into this last week but forgot to send the patch. Thanks. Looks good to me, thanks Arnd: Acked-by: Will Deacon On the topic of the timer stuff: Shinya/Stephen, did you have a chance to look at the registration stuff that was proposed? I'm happy to push it if people will actually use it. Cheers, Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/