Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933262Ab2HVS1C (ORCPT ); Wed, 22 Aug 2012 14:27:02 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:60611 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933208Ab2HVS05 (ORCPT ); Wed, 22 Aug 2012 14:26:57 -0400 MIME-Version: 1.0 In-Reply-To: <20120822181653.GB13623@infradead.org> References: <1345585940-6497-1-git-send-email-semenzato@chromium.org> <20120822072822.GA11042@gmail.com> <20120822162958.GA13623@infradead.org> <50350F2D.6030408@gmail.com> <20120822181653.GB13623@infradead.org> Date: Wed, 22 Aug 2012 11:26:56 -0700 X-Google-Sender-Auth: dEEn44T1F9O5SH4bgHNbfCpkyMg Message-ID: Subject: Re: [PATCH] perf: do not flush maps on COMM for perf report From: Luigi Semenzato To: Arnaldo Carvalho de Melo Cc: David Ahern , Ingo Molnar , Alexander Viro , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Andrew Morton , Vasiliy Kulikov , Stephen Wilson , Oleg Nesterov , Tejun Heo , Paul Gortmaker , Andi Kleen , Lucas De Marchi , Greg Kroah-Hartman , "Eric W. Biederman" , "Rafael J. Wysocki" , Frederic Weisbecker , Namhyung Kim , Robert Richter , linux-kernel@vger.kernel.org, sonnyrao@chromium.org, olofj@chromium.org, eranian@google.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 29 There is also this (incomplete, untested) patch, which shows what it takes to add the new record type. https://lkml.org/lkml/2012/3/2/345 On Wed, Aug 22, 2012 at 11:16 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 22, 2012 at 10:56:13AM -0600, David Ahern escreveu: >> On 8/22/12 10:29 AM, Arnaldo Carvalho de Melo wrote: >> >Adding the EXEC event, ditto. And I agree that while adding it we want >> >to do 1/2 as pre-requisite. >> >> maps should not be flushed on a COMM event, so that was a mistake. >> Given that what new information does an EXEC event provide? Same >> process id. A COMM event is generated on an exec, so the name change >> happens. Mappings are dropped prior to that - and there is no unmap >> event. That seems to be a missing piece. Maps are added which is >> handled by MMAP events. After that why is an exec event relevant? > > Please read the original discussion about it: > > https://lkml.org/lkml/2012/2/13/545 > > - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/