Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965090Ab2HVTZf (ORCPT ); Wed, 22 Aug 2012 15:25:35 -0400 Received: from ns1.pc-advies.be ([83.149.101.17]:52980 "EHLO spo001.leaseweb.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758943Ab2HVTZb (ORCPT ); Wed, 22 Aug 2012 15:25:31 -0400 Date: Wed, 22 Aug 2012 21:25:25 +0200 From: Wim Van Sebroeck To: Andi Kleen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mmarek@suse.cz, linux-kbuild@vger.kernel.org, JBeulich@suse.com, akpm@linux-foundation.org, Andi Kleen , Thomas Mingarelli Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global Message-ID: <20120822192525.GE27604@spo001.leaseweb.com> References: <1345345030-22211-1-git-send-email-andi@firstfloor.org> <1345345030-22211-39-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345345030-22211-39-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 22 Hi andi, > From: Andi Kleen > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: wim@iguana.be > Signed-off-by: Andi Kleen You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/