Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933310Ab2HVUp0 (ORCPT ); Wed, 22 Aug 2012 16:45:26 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:46418 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126Ab2HVUpX (ORCPT ); Wed, 22 Aug 2012 16:45:23 -0400 Message-ID: <503544DE.20003@wwwdotorg.org> Date: Wed, 22 Aug 2012 14:45:18 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: Thomas Petazzoni , Grant Likely , Rob Herring , Rob Landley , Russell King , Lior Amsalem , Andrew Lunn , Gregory CLEMENT , Ben Dooks , Linus Walleij , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 7/9] ARM: mvebu: Add pinctrl support to Armada XP SoCs References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1345623750-10645-1-git-send-email-sebastian.hesselbarth@gmail.com> <1345623750-10645-8-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1345623750-10645-8-git-send-email-sebastian.hesselbarth@gmail.com> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1805 Lines: 38 On 08/22/2012 02:22 AM, Sebastian Hesselbarth wrote: > This commits adds the necessary device tree information to define the > compatible property for the pinctrl driver instance of Armada XP SoCs. > > Until now, the device tree representation considered the Armada XP as > a single SoC. But in fact, there are three different SoCs in the > Armada XP families, with different number of CPU cores, different > number of Ethernet interfaces... and different number of muxable pins > or functions. We therefore introduce three armada-xp-mv78xx0.dtsi for > the three SoCs of the Armada XP family. The current armada-xp-db.dts > evaluation board uses the MV78460 variant of the SoC. > diff --git a/arch/arm/boot/dts/armada-xp-mv78230.dtsi b/arch/arm/boot/dts/armada-xp-mv78230.dtsi > +/include/ "armada-xp.dtsi" > + > +/ { > + model = "Marvell Armada XP family SoC"; > + compatible = "marvell,armadaxp-mv78230", "marvell,armadaxp", "marvell,armada-370-xp"; Since each of these files is specifically for a different SoC, I'd expect them all to say something different in the model property? > diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi > + model = "Marvell Armada XP family SoC"; > + compatible = "marvell,armadaxp-mv78260", "marvell,armadaxp", "marvell,armada-370-xp"; > diff --git a/arch/arm/boot/dts/armada-xp-mv78460.dtsi b/arch/arm/boot/dts/armada-xp-mv78460.dtsi > + model = "Marvell Armada XP family SoC"; > + compatible = "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp"; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/