Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932764Ab2HWLmm (ORCPT ); Thu, 23 Aug 2012 07:42:42 -0400 Received: from mga11.intel.com ([192.55.52.93]:35892 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756548Ab2HWLmg (ORCPT ); Thu, 23 Aug 2012 07:42:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,300,1344236400"; d="scan'208";a="212872794" Date: Thu, 23 Aug 2012 19:42:29 +0800 From: Fengguang Wu To: Anton Vorontsov , "Kim, Milo" Cc: Axel Lin , David Woodhouse , linux-kernel@vger.kernel.org Subject: [PATCH] lp8727_charger: use IRQF_ONESHOT Message-ID: <20120823114229.GA16789@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline User-Agent: Heirloom mailx 12.5 6/20/10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2125 Lines: 68 --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Signed-off-by: Fengguang Wu --- Note: I don't really know much about the situation, feel free to ignore it if it's an false warning. cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/power/lp8727_charger.c +++ b/drivers/power/lp8727_charger.c @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 return request_threaded_irq(pchg->client->irq, NULL, lp8727_isr_func, - IRQF_TRIGGER_FALLING, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lp8727_irq", pchg); } --sm4nu43k4a2Rpi4c Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="irqf_oneshot-lp8727_charger.patch" [PATCH] lp8727_charger: fix coccinelle warnings /c/kernel-tests/src/linux/drivers/power/lp8727_charger.c:255:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Signed-off-by: Fengguang Wu --- cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/power/lp8727_charger.c +++ b/drivers/power/lp8727_charger.c @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 return request_threaded_irq(pchg->client->irq, NULL, lp8727_isr_func, - IRQF_TRIGGER_FALLING, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lp8727_irq", pchg); } --sm4nu43k4a2Rpi4c-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/