Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757204Ab2HWL4z (ORCPT ); Thu, 23 Aug 2012 07:56:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:7166 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279Ab2HWL4v (ORCPT ); Thu, 23 Aug 2012 07:56:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,300,1344236400"; d="scan'208";a="184484026" Date: Thu, 23 Aug 2012 19:56:43 +0800 From: Fengguang Wu To: Anton Vorontsov Cc: David Woodhouse , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , NeilBrown Subject: [PATCH] twl4030_charger: use IRQF_ONESHOT Message-ID: <20120823115643.GA17927@localhost> References: <20120823114229.GA16789@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120823114229.GA16789@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 37 Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! drivers/power/twl4030_charger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800 +++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800 @@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru } ret = request_threaded_irq(bci->irq_chg, NULL, - twl4030_charger_interrupt, 0, pdev->name, bci); + twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci); if (ret < 0) { dev_err(&pdev->dev, "could not request irq %d, status %d\n", bci->irq_chg, ret); @@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru } ret = request_threaded_irq(bci->irq_bci, NULL, - twl4030_bci_interrupt, 0, pdev->name, bci); + twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci); if (ret < 0) { dev_err(&pdev->dev, "could not request irq %d, status %d\n", bci->irq_bci, ret); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/