Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932882Ab2HWMEo (ORCPT ); Thu, 23 Aug 2012 08:04:44 -0400 Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:40905 "EHLO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932566Ab2HWMEk (ORCPT ); Thu, 23 Aug 2012 08:04:40 -0400 Date: Thu, 23 Aug 2012 15:00:38 +0300 From: Felipe Balbi To: Fengguang Wu Cc: Anton Vorontsov , David Woodhouse , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , NeilBrown Subject: Re: [PATCH] twl4030_charger: use IRQF_ONESHOT Message-ID: <20120823120035.GM30710@arwen.pp.htv.fi> Reply-To: balbi@ti.com References: <20120823114229.GA16789@localhost> <20120823115643.GA17927@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QqzFzR/RUlLahzby" Content-Disposition: inline In-Reply-To: <20120823115643.GA17927@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3043 Lines: 84 --QqzFzR/RUlLahzby Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 23, 2012 at 07:56:43PM +0800, Fengguang Wu wrote: > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci >=20 > Make sure threaded IRQs without a primary handler are always request with= IRQF_ONESHOT >=20 > Signed-off-by: Fengguang Wu makes sense, NULL hardirq handler: Acked-by: Felipe Balbi > --- >=20 > Please take the patch only if it's a positive warning. Thanks! >=20 > drivers/power/twl4030_charger.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > --- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560= 783 +0800 > +++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 += 0800 > @@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru > } > =20 > ret =3D request_threaded_irq(bci->irq_chg, NULL, > - twl4030_charger_interrupt, 0, pdev->name, bci); > + twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci); > if (ret < 0) { > dev_err(&pdev->dev, "could not request irq %d, status %d\n", > bci->irq_chg, ret); > @@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru > } > =20 > ret =3D request_threaded_irq(bci->irq_bci, NULL, > - twl4030_bci_interrupt, 0, pdev->name, bci); > + twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci); > if (ret < 0) { > dev_err(&pdev->dev, "could not request irq %d, status %d\n", > bci->irq_bci, ret); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ --=20 balbi --QqzFzR/RUlLahzby Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQNhtjAAoJEIaOsuA1yqREUDYP+wXyP+RL3xA8EAUZVnaRqXeV nmwwRw1cbnmv7Ra71qX0oMVfumcmbL5S/Jq+NNkRM1yQAbHRO+WYW5VHSJhJXDLb AxSY2qtJi+XlMI8e7GUDLB7MXpIocRwFE88laEPGJtPjo7URt7/0jTpey6AA0jJU aYES3S6jjum2JDHrN+ujz/1wYxA3BhbJxwhEhkAXjPJGvkh6skU6Wh3Xb4ba1L2m JrUWyYXckUWweMQS5O0aOx6LLSqYn3wjdDw0d5QuHZG6O/RQ3hweyDlp+/BIf2jR NVlnNzYCMp9TGO0Ui21wLYtSMWPsuTME4khi3KbbwzuV/ycqFTebbQxrPXisrBEp Csa3V1W3rL9b+Kper5hunVpaxY9xGig8865AMb/EHEih7QvLzCmflma8tD+ESifk wXDd91fknamHuqrqJe7vdW++HS+rRVGJj6udGcbrR5kGKCACWkpA8xQ0fj3ZAsoi 5ti1i4PxNyyWy9/1uRmgeTS9Z+Cm4uxpxPAfKqm5WpXzwGxttxrxMnY44FLGoJ7b D205kdH32Zq1Y9iUi7U5xjx5elbE9hQB0ix8mOhmQPf+r6nWcTI2HWWdxH1wUK4a HvJwnoUxvWutlZi8PJwTJeILjZgL5K9P3I0lgHGZVgQz/UB/+AQMnJ3tTGWqsR5J iSyWkPDbbk4KJvznQj7g =g/Cc -----END PGP SIGNATURE----- --QqzFzR/RUlLahzby-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/