Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759053Ab2HWPZT (ORCPT ); Thu, 23 Aug 2012 11:25:19 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:44141 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756004Ab2HWPZO (ORCPT ); Thu, 23 Aug 2012 11:25:14 -0400 MIME-Version: 1.0 In-Reply-To: <5036234A.7060102@snapgear.com> References: <1345551531-15348-1-git-send-email-stany.marcel@novasys-ingenierie.com> <5036234A.7060102@snapgear.com> Date: Thu, 23 Aug 2012 17:25:12 +0200 X-Google-Sender-Auth: oDntKQ9lfG8OvwWcAed35QNQzRI Message-ID: Subject: Re: [PATCH 1/3] Add support to broadcom 5222 PHY From: Stany MARCEL To: Greg Ungerer Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1536 Lines: 53 On Thu, Aug 23, 2012 at 2:34 PM, Greg Ungerer wrote: > Hi Stany, > > > On 08/23/2012 08:47 PM, Geert Uytterhoeven wrote: >> >> On Tue, Aug 21, 2012 at 2:18 PM, Stany MARCEL >> wrote: >>> >>> Signed-off-by: Stany MARCEL >>> --- >>> >>> This driver is an adaption of the one given by freescale for kernel >>> 2.6.25. >>> >>> Tested with kernel 3.4.8 with arch/m68k backported from linux-m68k head >>> 2 FEC configured with shared phy >>> >>> drivers/net/phy/Kconfig | 7 +- >>> drivers/net/phy/Makefile | 1 + >>> drivers/net/phy/broadcom522x.c | 171 >>> ++++++++++++++++++++++++++++++++++++++++ >> >> >> This patch and "[PATCH 3/3] Add support to M54xx DMA FEC Driver" need to >> go >> through the netdev tree, or collect acks there. > > > And patch 2/3 never made it to the linux-m68k list. Though I can see > that it made it onto the linux-kernel list. > > I would suggest running them through checkpatch, there is a number of > formating and the like issues that need cleaning up. > > Also you will want to break up patch 2. It is a bit large to be reviewed > the way it is. > > Regards > Greg Hi Greg I will rework my patches and resend them. Regards, Stany -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/