Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934279Ab2HWSz5 (ORCPT ); Thu, 23 Aug 2012 14:55:57 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:37344 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934224Ab2HWSzw (ORCPT ); Thu, 23 Aug 2012 14:55:52 -0400 From: Benjamin Poirier To: Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap , Borislav Petkov , "Yann E. MORIN" , Jean Sacren , Arnaud Lacombe , Lucas De Marchi , Davidlohr Bueso , Wang YanQing , Paul Gortmaker , Cheng Renquan Subject: [PATCH v2 1/6] menuconfig: Remove superfluous conditionnal Date: Thu, 23 Aug 2012 14:55:03 -0400 Message-Id: <1345748108-12206-2-git-send-email-bpoirier@suse.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1345748108-12206-1-git-send-email-bpoirier@suse.de> References: <1345748108-12206-1-git-send-email-bpoirier@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 43 Because end_reached is set to 0 before the loop, the test "!end_reached" is always true and can be removed. This structure was perhaps copied from the similar one in back_lines(). Signed-off-by: Benjamin Poirier --- scripts/kconfig/lxdialog/textbox.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c index 4e5de60..264a2b9 100644 --- a/scripts/kconfig/lxdialog/textbox.c +++ b/scripts/kconfig/lxdialog/textbox.c @@ -357,10 +357,8 @@ static char *get_line(void) end_reached = 0; while (*page != '\n') { if (*page == '\0') { - if (!end_reached) { - end_reached = 1; - break; - } + end_reached = 1; + break; } else if (i < MAX_LEN) line[i++] = *(page++); else { @@ -373,7 +371,7 @@ static char *get_line(void) if (i <= MAX_LEN) line[i] = '\0'; if (!end_reached) - page++; /* move pass '\n' */ + page++; /* move past '\n' */ return line; } -- 1.7.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/