Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756998Ab2HWUbK (ORCPT ); Thu, 23 Aug 2012 16:31:10 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:35065 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641Ab2HWUbH (ORCPT ); Thu, 23 Aug 2012 16:31:07 -0400 Message-ID: <50369305.6050304@gmail.com> Date: Thu, 23 Aug 2012 22:31:01 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: Stephen Warren CC: Thomas Petazzoni , Grant Likely , Rob Herring , Rob Landley , Russell King , Lior Amsalem , Andrew Lunn , Gregory CLEMENT , Ben Dooks , Linus Walleij , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/9] pinctrl: mvebu: pinctrl driver core References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1345623750-10645-1-git-send-email-sebastian.hesselbarth@gmail.com> <1345623750-10645-2-git-send-email-sebastian.hesselbarth@gmail.com> <5035445B.6000500@wwwdotorg.org> <50366E44.4030606@wwwdotorg.org> In-Reply-To: <50366E44.4030606@wwwdotorg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1923 Lines: 36 On 08/23/2012 07:54 PM, Stephen Warren wrote: >> dt_parse() and dt_parse_function() build up structs that get used later on >> in mvebu_pinmux_ops that require indexed functions. I can join them with >> dt_node_to_map() but that would require incremental kzalloc for the >> corresponding array. Or I could (functionally) leave dt_parse() to allocate >> the array and only join dt_parse_function() with dt_node_to_map(). > > So everything you said makes sense, in that the core driver is > parameterizable and receives data from a SoC-variant-specific driver > indicating which pins/groups/functions are available. I'm still not sure > though why the translation of the pin/group/function structures passed > to probe into other data structures requires accessing the DT at all; > the set of available pins/groups/functions isn't configured through DT, > and doesn't need to be limited to only those options actually used in > DT, so can't you just process all the data that's passed to probe > without interaction with the DT? Hmm, maybe I still don't quite understand the terminology of pinctrl/pinmux core completely. What exactly should mvebu_pinmux_get_funcs_count return if not the number of DT node children? I thought that a "function" in the terminology of pinctrl/pinmux core is a list of pingroups and corresponding values to actually set it to e.g. uart1. In pinctrl-mvebu this would be one marvell,function assigned to one or more marvell,pins. If the above is correct, I still need to access DT in probe() at least to count the number of children passed to allocate an array for mvebu_pinmux_ops callbacks that get indexed by "fid" (pctl->functions). Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/