Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757501Ab2HXBOz (ORCPT ); Thu, 23 Aug 2012 21:14:55 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:60553 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754617Ab2HXBOt (ORCPT ); Thu, 23 Aug 2012 21:14:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1345499431-21658-1-git-send-email-jmillenbach@gmail.com> <20120821142047.777e4bb0@pyramind.ukuu.org.uk> Date: Thu, 23 Aug 2012 18:14:48 -0700 Message-ID: Subject: Fwd: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY From: Joe Millenbach To: Alan Cox Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Triplett , team-fjord@googlegroups.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1827 Lines: 50 ---------- Forwarded message ---------- From: Joe Millenbach Date: Thu, Aug 23, 2012 at 5:56 PM Subject: Re: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY To: Alan Cox Cc: Greg Kroah-Hartman , Alan Cox , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Triplett , team-fjord@googlegroups.com On Tue, Aug 21, 2012 at 6:20 AM, Alan Cox wrote: > > ... > > > config MOUSE_PS2 > > tristate "PS/2 mouse" > > + depends on TTY > > It shouldn't. It would be good to understand why this occurs. If I enable this config option, and turn off TTY I get the below errors. drivers/built-in.o: In function `serport_ldisc_read': serport.c:(.text+0x1aace6): undefined reference to `tty_name' serport.c:(.text+0x1aad57): undefined reference to `tty_name' drivers/built-in.o: In function `serport_init': serport.c:(.init.text+0x8478): undefined reference to `tty_register_ldisc' drivers/built-in.o: In function `serport_exit': serport.c:(.exit.text+0xb29): undefined reference to `tty_unregister_ldisc' All because MOUSE_PS2 depends on SERIO, just like a lot of entries I blocked. I assume this means I should keep the dependency on TTY. Unfortunately, I don't have time to dig deeper for the true cause of the dependency right now. - Joe * Resending message as I forgot to turn off HTML messaging in Gmail (sorry), and I've heard SPAM blockers might eat HTML messages sent to LKML people. - Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/