Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932947Ab2HXCji (ORCPT ); Thu, 23 Aug 2012 22:39:38 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:43999 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757977Ab2HXCjL (ORCPT ); Thu, 23 Aug 2012 22:39:11 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6813"; a="226586837" X-IronPort-AV: E=Sophos;i="4.80,301,1344236400"; d="scan'208";a="374748747" From: "Huang, Xiong" To: Ben Hutchings CC: David Miller , "Ren, Cloud" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Rodriguez, Luis" Subject: RE: [PATCH v2] net: add new QCA alx ethernet driver Thread-Topic: [PATCH v2] net: add new QCA alx ethernet driver Thread-Index: AQHNfq/QcigpFEkeAUuvSgE/Sf2tgZdnYDEA//+NnwCAAXEzAP//2OtggAB7GQD//5FtAA== Date: Fri, 24 Aug 2012 02:39:03 +0000 Message-ID: <157393863283F442885425D2C45428562A4F5546@nasanexd02f.na.qualcomm.com> References: <1345480949-14800-1-git-send-email-cjren@qca.qualcomm.com> <20120822.225700.714020017287504609.davem@davemloft.net> <157393863283F442885425D2C45428562A4F5169@nasanexd02f.na.qualcomm.com> <1345756142.2579.16.camel@bwh-desktop.uk.solarflarecom.com> <157393863283F442885425D2C45428562A4F54E3@nasanexd02f.na.qualcomm.com> <1345774184.2579.51.camel@bwh-desktop.uk.solarflarecom.com> In-Reply-To: <1345774184.2579.51.camel@bwh-desktop.uk.solarflarecom.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.48.1] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q7O2dsHw001010 Content-Length: 466 Lines: 11 > > If you want to implement a more sophisticated packet matching mode that > requires more details than struct ethtool_wolinfo, then you may need to > define new operations. > It's great ! Is it ok for ethtool to define a new operation with a sophisticated structure (like ethtool_eee) ? Thanks Xiong ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?