Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756911Ab2HXHht (ORCPT ); Fri, 24 Aug 2012 03:37:49 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:39801 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754810Ab2HXHhr (ORCPT ); Fri, 24 Aug 2012 03:37:47 -0400 Date: Fri, 24 Aug 2012 13:07:38 +0530 From: Ananth N Mavinakayanahalli To: Benjamin Herrenschmidt Cc: Michael Ellerman , ppcdev , lkml , Paul Mackerras , Anton Blanchard , peterz@infradead.org, oleg@redhat.com, Srikar Dronamraju , Ingo Molnar Subject: Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc Message-ID: <20120824073738.GD32031@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20120822082205.GA29216@in.ibm.com> <20120822082708.GB29216@in.ibm.com> <1345696100.3338.21.camel@concordia> <20120823055820.GA14603@in.ibm.com> <1345770803.13865.10.camel@concordia> <1345792051.29170.25.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345792051.29170.25.camel@pasglop> User-Agent: Mutt/1.5.17 (2007-11-01) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12082407-2356-0000-0000-0000018C758E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 21 On Fri, Aug 24, 2012 at 05:07:31PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote: > > > > Yeah. A NULL regs here is a kernel bug, so I think it's actually > > preferable to crash than silently return. > > Or best, if you think there's a remote chance that the bug might hit: > > if (WARN(!regs)) > return Incorporated this and other suggestions from Michael in v5 I just posted. Ananth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/