From: Oliver Neukum <oneukum@suse.de>
To: Yann Cantin <yann.cantin@laposte.net>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
        gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.
Date: Fri, 24 Aug 2012 13:41:04 +0200
Message-ID: <1555763.Oi7gGGn7BU@linux-lqwf.site>
Organization: SUSE
User-Agent: KMail/4.8.4 (Linux/3.6.0-rc2-12-desktop+; KDE/4.8.5; x86_64; ; )
In-Reply-To: <50374B69.3040002@laposte.net>
References: <1345673514-11575-1-git-send-email-yann.cantin@laposte.net> <1368810.q4rGz16CTW@linux-lqwf.site> <50374B69.3040002@laposte.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 695
Lines: 22

On Friday 24 August 2012 11:37:45 Yann Cantin wrote:
> Hi,
> 
> Le 23/08/2012 09:23, Oliver Neukum a ?crit :
> > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:

> > These functions are identical. You should unify them.
> 
> Removed reset_resume from the driver (optional, and not needed
> for this hardware).

Why did you do that? It is always better to have reset_resume().
And you cannot tell whether it will be needed.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/