Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759634Ab2HXPjI (ORCPT ); Fri, 24 Aug 2012 11:39:08 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:28885 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759036Ab2HXPjF (ORCPT ); Fri, 24 Aug 2012 11:39:05 -0400 Date: Fri, 24 Aug 2012 17:39:02 +0200 From: Sam Ravnborg To: Wanpeng Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , KAMEZAWA Hiroyuki , Minchan Kim , Andrew Morton , Gavin Shan Subject: Re: [PATCH 2/5] mm/memblock: rename get_allocated_memblock_reserved_regions_info() Message-ID: <20120824153902.GA22555@merkur.ravnborg.org> References: <1345818820-12102-1-git-send-email-liwanp@linux.vnet.ibm.com> <1345818820-12102-2-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345818820-12102-2-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 34 On Fri, Aug 24, 2012 at 10:33:37PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Rename get_allocated_memblock_reserved_regions_info() to > memblock_reserved_regions_info() so that the function name > looks more short and has prefix "memblock". > > Signed-off-by: Wanpeng Li > --- > include/linux/memblock.h | 2 +- > mm/memblock.c | 2 +- > mm/nobootmem.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 569d67d..ab7b887 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -50,7 +50,7 @@ phys_addr_t memblock_find_in_range_node(phys_addr_t start, phys_addr_t end, > phys_addr_t size, phys_addr_t align, int nid); > phys_addr_t memblock_find_in_range(phys_addr_t start, phys_addr_t end, > phys_addr_t size, phys_addr_t align); > -phys_addr_t get_allocated_memblock_reserved_regions_info(phys_addr_t *addr); > +phys_addr_t memblock_reserved_regions_info(phys_addr_t *addr); When you anyway change the prototype a description of what this function is supposed to be used for would be good. Many memblock function lacks this :-( Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/