Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030524Ab2HXVLO (ORCPT ); Fri, 24 Aug 2012 17:11:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54489 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757675Ab2HXVLJ (ORCPT ); Fri, 24 Aug 2012 17:11:09 -0400 Date: Fri, 24 Aug 2012 14:11:08 -0700 From: Andrew Morton To: Ed Cashin Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/14] aoe: for performance support larger packet payloads Message-Id: <20120824141108.27da5e79.akpm@linux-foundation.org> In-Reply-To: <7c895879cfd1e15dd76c2469b417b48d0462d7df.1345743801.git.ecashin@coraid.com> References: <7c895879cfd1e15dd76c2469b417b48d0462d7df.1345743801.git.ecashin@coraid.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 23 On Fri, 17 Aug 2012 21:18:37 -0400 Ed Cashin wrote: > --- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -279,6 +279,9 @@ aoeblk_gdalloc(void *vp) > if (bdi_init(&d->blkq->backing_dev_info)) > goto err_blkq; > spin_lock_irqsave(&d->lock, flags); > + blk_queue_max_hw_sectors(d->blkq, BLK_DEF_MAX_SECTORS); > + d->blkq->backing_dev_info.ra_pages = BLK_DEF_MAX_SECTORS * 1024; > + d->blkq->backing_dev_info.ra_pages /= PAGE_CACHE_SIZE; This seems a bit abusive of BLK_DEF_MAX_SECTORS, which is in units of 512-byte sectors. (BLK_DEF_MAX_SECTORS * 512)/PAGE_CACHE_SIZE would make sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/