Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051Ab2HYVgP (ORCPT ); Sat, 25 Aug 2012 17:36:15 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40468 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016Ab2HYVgM (ORCPT ); Sat, 25 Aug 2012 17:36:12 -0400 X-Sasl-enc: vEjcbPaFBYpvoUdDgNpaq/8/43605aA0GoA+tDxq4geV 1345930571 Message-ID: <50394549.5070308@fastmail.fm> Date: Sat, 25 Aug 2012 23:36:09 +0200 From: Bernd Schubert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Christopher Sacchi CC: linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , "linux-ext4@vger.kernel.org" Subject: Re: [PATCH]:dir.c patch References: In-Reply-To: X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 31 On 08/25/2012 10:37 PM, Christopher Sacchi wrote: > Here is a non-style issue dir.c-patch, and as far as I can see from > the lines of code, the compilation errors weren't about what I put in. > This patch fixes a "break" statement inside an "if" statement, as > obviously not correct. Why should that not be correct? It breaks the while(1) loop? > Here's the patch for the kernel version v3.6.0rc3: > > -- > Signed-off-by: Christopher P. Sacchi > --- dir.c 2012-08-25 15:47:24.260443900 -0400 > +++ dir.c 2012-08-25 16:02:05.458845600 -0400 > @@ -580,7 +580,6 @@ static int ext4_dx_readdir(struct file * > return ret; > if (ret == 0) { > filp->f_pos = ext4_get_htree_eof(filp); > - break; So ext4_htree_fill_tree() did not return more entries and the while(1) loop shall be stopped? Cheers, Bernd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/