Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752839Ab2H0OjB (ORCPT ); Mon, 27 Aug 2012 10:39:01 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:43252 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752513Ab2H0Oi5 (ORCPT ); Mon, 27 Aug 2012 10:38:57 -0400 Date: Mon, 27 Aug 2012 10:38:56 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Julia Lawall cc: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , , Subject: Re: [PATCH 4/6] drivers/usb/host/ohci-nxp.c: adjust inconsistent IS_ERR and PTR_ERR In-Reply-To: <1345924629-16584-5-git-send-email-Julia.Lawall@lip6.fr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 32 On Sat, 25 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Change the call to PTR_ERR to access the value just tested by IS_ERR. > Signed-off-by: Julia Lawall > > --- > drivers/usb/host/ohci-nxp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c > index a446386..c60066a 100644 > --- a/drivers/usb/host/ohci-nxp.c > +++ b/drivers/usb/host/ohci-nxp.c > @@ -355,7 +355,7 @@ static int __devinit usb_hcd_nxp_probe(struct platform_device *pdev) > usb_otg_clk = clk_get(&pdev->dev, "ck_usb_otg"); > if (IS_ERR(usb_otg_clk)) { > dev_err(&pdev->dev, "failed to acquire USB DEV Clock\n"); > - ret = PTR_ERR(usb_dev_clk); > + ret = PTR_ERR(usb_otg_clk); > goto out6; > } Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/