Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687Ab2H0Vij (ORCPT ); Mon, 27 Aug 2012 17:38:39 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39366 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329Ab2H0Vii (ORCPT ); Mon, 27 Aug 2012 17:38:38 -0400 Date: Mon, 27 Aug 2012 14:38:35 -0700 From: Mark Brown To: Janusz Krzysztofik Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: ams-delta: fix card initalization failure Message-ID: <20120827213835.GE4400@opensource.wolfsonmicro.com> References: <1346102910-8610-1-git-send-email-jkrzyszt@tis.icnet.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346102910-8610-1-git-send-email-jkrzyszt@tis.icnet.pl> X-Cookie: You will forget that you ever knew me. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 16 On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote: > - platform_set_drvdata(ams_delta_audio_platform_device, > - &ams_delta_audio_card); > - > - ret = platform_device_add(ams_delta_audio_platform_device); > - if (ret) > - goto err; The real fix here is that you should be using platform data here, not driver data. Is there some reason not to do that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/