Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495Ab2H1C3t (ORCPT ); Mon, 27 Aug 2012 22:29:49 -0400 Received: from [216.32.181.182] ([216.32.181.182]:19525 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751002Ab2H1C3r (ORCPT ); Mon, 27 Aug 2012 22:29:47 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: 1 X-BigFish: VS1(zz98dI1432Izz1202h1082kzzz2dh2a8h668h839h944hd25hf0ah107ah1155h) Date: Tue, 28 Aug 2012 10:08:07 +0800 From: Dong Aisheng To: Shawn Guo CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linus.walleij@stericsson.com" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "grant.likely@secretlab.ca" , "rob.herring@calxeda.com" , "sameo@linux.intel.com" , "lrg@ti.com" , "broonie@opensource.wolfsonmicro.com" , Zhao Richard-B20223 , "devicetree-discuss@lists.ozlabs.org" , "swarren@wwwdotorg.org" Subject: Re: [PATCH v2 4/7] regulator: anatop-regulator: convert to use syscon to access anatop register Message-ID: <20120828020806.GE5822@shlinux2.ap.freescale.net> References: <1346052285-4344-1-git-send-email-b29396@freescale.com> <1346052285-4344-5-git-send-email-b29396@freescale.com> <20120827221532.GC2281@r65073-Latitude-D630> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120827221532.GC2281@r65073-Latitude-D630> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 22 On Tue, Aug 28, 2012 at 06:15:35AM +0800, Shawn Guo wrote: .... > > + sreg->anatop = syscon_regmap_lookup_by_phandle(np, "fsl,anatop"); > > + if (IS_ERR(sreg->anatop)) > > + return PTR_ERR(sreg->anatop); > > + > > All the anatop regulators are child nodes of anatop. It looks a little > odd to use phandle there. of_get_parent should just works. > Yes, this is a special case. It's also ok for me to use of_get_parent if you want. Will update it. Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/