Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474Ab2H1HEK (ORCPT ); Tue, 28 Aug 2012 03:04:10 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:63533 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977Ab2H1HEJ (ORCPT ); Tue, 28 Aug 2012 03:04:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1346090307-3020-1-git-send-email-laijs@cn.fujitsu.com> <1346090307-3020-7-git-send-email-laijs@cn.fujitsu.com> <20120827200510.GB14812@dhcp-172-17-108-109.mtv.corp.google.com> Date: Tue, 28 Aug 2012 00:04:07 -0700 X-Google-Sender-Auth: gf_BA9U-9bTQMKtv2aei0gxt8N8 Message-ID: Subject: Re: [PATCH 6/7] workqueue: init 0 for idle_rebind.cnt From: Tejun Heo To: Lai Jiangshan Cc: Lai Jiangshan , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 21 Hello, On Mon, Aug 27, 2012 at 9:36 PM, Lai Jiangshan wrote: >> But then the completion could be triggered prematurely, no? > > No, the idle_worker_rebind() can't be called until rebind_workers() > finish counting and release the gcwq->lock. I see but I still wanna keep it counting from 1. That's an established pattern and is more robust. I really don't see what we're gaining by doing it differently. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/