Date: Tue, 28 Aug 2012 12:14:52 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Jeff Moyer <jmoyer@redhat.com>, Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jens Axboe <jaxboe@fusionio.com>,
        Torsten Hilbrich <torsten.hilbrich@secunet.com>,
        Josh Boyer <jwboyer@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix
Message-ID: <20120828111452.GH5234@rhmail.home.annexia.org>
References: <alpine.LSU.2.00.1208211826270.2488@eggly.anvils>
 <20120822115243.GU1448@rhmail.home.annexia.org>
 <alpine.LSU.2.00.1208222143440.1917@eggly.anvils>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.00.1208222143440.1917@eggly.anvils>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1841
Lines: 44

On Wed, Aug 22, 2012 at 09:56:12PM -0700, Hugh Dickins wrote:
> On Wed, 22 Aug 2012, Richard W.M. Jones wrote:
> > On Tue, Aug 21, 2012 at 06:33:45PM -0700, Hugh Dickins wrote:
> > > Jeff,
> > > 
> > > Your commit 91f68c89d8f3 ("block: fix infinite loop in __getblk_slow"),
> > > already gone into 3.* stable, is not good.  Could you and your testers
> > > please give this alternative a try - I think it should work, and have
> > > started it on a few days' memory load on 3.5, but not tried your case.
> > 
> > I have tested your patch and it does NOT fix the problem in
> > http://bugzilla.redhat.com/835019
> > Kernel 3.6.0 + your patch => mount goes into a loop when mounting
> > a small empty partition.  Please do NOT apply this as it will
> > cause a regression!
> 
> That was all very helpful information that you provided, thank you.
> Sorry, I had missed how "block" is massaged as it's passed down a level.
> 
> The patch below fixes it for me, though it does have to change more than
> I'd been hoping in such a fix.  Perhaps I am just being silly to resist
> repeating the call to blkdev_max_block().  Does this patch work for you?
> 
> Thanks,
> Hugh
> 
> [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix

I noticed this (second version) went upstream already.  Nevertheless I
tested it today and it doesn't cause a regression of RHBZ#835019.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/