Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693Ab2H2G3h (ORCPT ); Wed, 29 Aug 2012 02:29:37 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:46270 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160Ab2H2G3g (ORCPT ); Wed, 29 Aug 2012 02:29:36 -0400 Message-ID: <503DB6CD.4070502@gmail.com> Date: Wed, 29 Aug 2012 00:29:33 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "Suzuki K. Poulose" CC: Arnaldo Carvalho de Melo , LKML , Frederic Weisbecker , ananth@in.ibm.com, Ingo Molnar , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [PATCH] [perf] Remove the node from rblist in strlist__remove References: <20120829055840.7802.1459.stgit@suzukikp.in.ibm.com> In-Reply-To: <20120829055840.7802.1459.stgit@suzukikp.in.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2160 Lines: 58 On 8/29/12 12:00 AM, Suzuki K. Poulose wrote: > The following commit: > > author David Ahern > Tue, 31 Jul 2012 04:31:33 +0000 (22:31 -0600) > committer Arnaldo Carvalho de Melo > Fri, 3 Aug 2012 13:39:51 +0000 (10:39 -0300) > commit ee8dd3ca43f151d9fbe1edeef68fb8a77eb9f047 > > causes a double free during a probe deletion as the node is > never removed from the list via strlist__remove(), even though > it gets 'deleted' (read free()'d). This causes a double > free when we do strlist__delete() as the node is already deleted > but present in the rblist. > > [suzukikp@suzukikp perf]$ sudo ./perf probe -a do_fork > Added new event: > probe:do_fork (on do_fork) > > You can now use it in all perf tools, such as: > > perf record -e probe:do_fork -aR sleep 1 > > [suzukikp@suzukikp perf]$ sudo ./perf probe -d do_fork > Removed event: probe:do_fork > *** glibc detected *** ./perf: double free or corruption (fasttop): 0x000000000133d600 *** > ======= Backtrace: ========= > /lib64/libc.so.6[0x38eec7dda6] > ./perf(rblist__delete+0x5c)[0x47d3dc] > ./perf(del_perf_probe_events+0xb6)[0x47b826] > ./perf(cmd_probe+0x471)[0x42c8d1] > ./perf[0x4150b3] > ./perf(main+0x501)[0x4148e1] > /lib64/libc.so.6(__libc_start_main+0xed)[0x38eec2169d] > ./perf[0x414a61] > > > Make sure we remove the node from the rblist before we delete the > node. The rblist__remove_node() will invoke rblist->node_delete, > which will take care of deleting the node with the suitable function > provided by the user. > > Reported-by: Ananth N. Mavinakayanahalli > Signed-off-by: Suzuki K. Poulose > Cc: David Ahern > Cc: Arnaldo Carvalho de Melo Acked-by: David Ahern Same type of change is needed for util/intlist.c if you want to submit one, otherwise I will take care of it. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/