Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371Ab2H3KP0 (ORCPT ); Thu, 30 Aug 2012 06:15:26 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:42971 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821Ab2H3KPZ (ORCPT ); Thu, 30 Aug 2012 06:15:25 -0400 MIME-Version: 1.0 In-Reply-To: <503DFFF4.4060909@mellanox.com> References: <503CA1A2.90104@mellanox.com> <503DFFF4.4060909@mellanox.com> Date: Thu, 30 Aug 2012 13:15:24 +0300 X-Google-Sender-Auth: 8geD-nAVZG4nMFrAXSUPiT2Xg1s Message-ID: Subject: Re: [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs From: Pekka Enberg To: Haggai Eran Cc: David Rientjes , Linus Torvalds , Mel Gorman , LKML , Or Gerlitz , Shachar Raindel , Christoph Lameter Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 17 On Wed, Aug 29, 2012 at 2:41 PM, Haggai Eran wrote: >> Looks like a problem in 072bb0aa5e0 ("mm: sl[au]b: add knowledge of >> PFMEMALLOC reserve pages"). cache_grow() can reenable irqs which allows >> this to be scheduled on a different cpu, possibly with a different node. >> So it turns out that we lock the wrong node's list_lock because we don't >> check the new node id when irqs are disabled again. >> >> I doubt you can reliably reproduce this, but the following should fix the >> issue. > Your patch did solve the issue. Thanks! Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/