Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176Ab2H3MJT (ORCPT ); Thu, 30 Aug 2012 08:09:19 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:53933 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797Ab2H3MJR (ORCPT ); Thu, 30 Aug 2012 08:09:17 -0400 Date: Thu, 30 Aug 2012 05:06:51 -0700 From: Anton Vorontsov To: "Kim, Milo" Cc: Axel Lin , David Woodhouse , "linux-kernel@vger.kernel.org" , Fengguang Wu Subject: Re: [PATCH] lp8727_charger: use IRQF_ONESHOT Message-ID: <20120830120651.GA10779@lizard> References: <20120823114229.GA16789@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 46 On Thu, Aug 30, 2012 at 11:41:54AM +0000, Kim, Milo wrote: > > > ERROR: Threaded IRQ with no primary handler requested without > > > IRQF_ONESHOT > > > > > > Make sure threaded IRQs without a primary handler are always request > > > with IRQF_ONESHOT > > > > > > Signed-off-by: Fengguang Wu > > > --- > > > > > > Note: I don't really know much about the situation, feel free to > > > ignore it if it's an false warning. > > > > > > cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- a/drivers/power/lp8727_charger.c > > > +++ b/drivers/power/lp8727_charger.c > > > @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 > > > return request_threaded_irq(pchg->client->irq, > > > NULL, > > > lp8727_isr_func, > > > - IRQF_TRIGGER_FALLING, > > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > > > "lp8727_irq", > > > pchg); > > > } > > Thanks for the update. > > > > Acked-by: Milo(Woogyom) Kim > > > > Please refer to the patch below. > [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code > This includes previous Fengguang' patch. Nope, I'll include Fengguang's patch (he posted it first), and then will try to apply the rest of your cleanups on top of it. If it helps, your can incorporate the fix in your series, preserving the authorship. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/