Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533Ab2H3MRs (ORCPT ); Thu, 30 Aug 2012 08:17:48 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:47416 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897Ab2H3MRr (ORCPT ); Thu, 30 Aug 2012 08:17:47 -0400 Date: Thu, 30 Aug 2012 05:15:21 -0700 From: Anton Vorontsov To: "Kim, Milo" Cc: "linux-kernel@vger.kernel.org" , David Woodhouse Subject: Re: [PATCH 0/8] lp8727_charger: cleanup code Message-ID: <20120830121521.GC11289@lizard> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 23 On Thu, Aug 30, 2012 at 11:37:16AM +0000, Kim, Milo wrote: > LP8727 driver should be patched for several reasons. > > (a) Need to clean up _probe()/_remove() > (b) Not secure code when the platform data is NULL > (c) Interrupt handling > Two threads are running for handling one IRQ. > One is for the IRQ pin, the other is used for delayed processing. > This is unusual and can be enhanced. > (d) Misuse of mutex code > (e) Lots of definitions should be fixed > (f) Others.. Thanks a lot for the cleanups, this is much appreciated! The cleanups themselves look great, but I'd really like to see them more separated. Thanks, Anton. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/