Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687Ab2HaK7X (ORCPT ); Fri, 31 Aug 2012 06:59:23 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:48525 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780Ab2HaK7W (ORCPT ); Fri, 31 Aug 2012 06:59:22 -0400 Date: Fri, 31 Aug 2012 11:59:01 +0100 From: Russell King - ARM Linux To: Alan Cox Cc: Matthieu CASTET , "arnd@arndb.de" , "gregkh@suse.de" , "sboyd@codeaurora.org" , "linux-kernel@vger.kernel.org" , Matthieu CASTET , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] hvc_dcc : add support to armv4 and armv5 core Message-ID: <20120831105901.GF18957@n2100.arm.linux.org.uk> References: <1346404916-27616-1-git-send-email-castet.matthieu@free.fr> <20120831110444.25d9b9fe@pyramind.ukuu.org.uk> <504091F0.1090703@parrot.com> <20120831103351.GE18957@n2100.arm.linux.org.uk> <20120831115939.23fd4a08@pyramind.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120831115939.23fd4a08@pyramind.ukuu.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 37 On Fri, Aug 31, 2012 at 11:59:39AM +0100, Alan Cox wrote: > On Fri, 31 Aug 2012 11:33:51 +0100 > Russell King - ARM Linux wrote: > > > On Fri, Aug 31, 2012 at 12:29:04PM +0200, Matthieu CASTET wrote: > > > Alan Cox a ?crit : > > > > On Fri, 31 Aug 2012 11:21:56 +0200 > > > > Matthieu CASTET wrote: > > > > > > > >> Signed-off-by: Matthieu Castet > > > >> --- > > > >> drivers/tty/hvc/hvc_dcc.c | 34 ++++++++++++++++++++++++++++++++++ > > > >> 1 file changed, 34 insertions(+) > > > > > > > > This is a step in the wrong direction. This should all be runtime handled > > > > > > > > NAK. > > > > > > > > > > AFAIK you can't build a arm kernel that support arm6/armv7 and armv5. > > > And I am not sure it will be possible one day. > > > > There are no plans to ever make it possible; there are too many significant > > differences between ARMv4, v5 architectures and ARMv6,v7 architectures > > to warrant making this runtime selectable. > > Then bury this crap in platform files please not in the drivers/tty layer > code. Make it a platform driver provided callback or something. Platform driver callbacks via platform data are incompatible with DT, which is where folk elsewhere in the kernel community have kicked ARM towards, away from the platform driver/device with platform data model. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/