Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755033Ab2HaVYm (ORCPT ); Fri, 31 Aug 2012 17:24:42 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53402 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509Ab2HaVYl (ORCPT ); Fri, 31 Aug 2012 17:24:41 -0400 Date: Fri, 31 Aug 2012 14:24:36 -0700 From: Mark Brown To: Prasad Joshi Cc: lrg@ti.com, perex@perex.cz, tiwai@suse.de, rajeev-dlh.kumar@st.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: correct the check for NULL dma_buffer pointer Message-ID: <20120831212435.GB5495@opensource.wolfsonmicro.com> References: <1346383521-2990-1-git-send-email-prasadjoshi.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346383521-2990-1-git-send-email-prasadjoshi.linux@gmail.com> X-Cookie: You will forget that you ever knew me. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 522 Lines: 14 On Fri, Aug 31, 2012 at 08:55:21AM +0530, Prasad Joshi wrote: > The if condition > if (!buf && !buf->area) > > checks if the buf pointer is NULL and then dereferences it again to > check if the buffer area is NULL, resulting in possible NULL > dereference. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/