Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000Ab2JAQCW (ORCPT ); Mon, 1 Oct 2012 12:02:22 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:63874 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350Ab2JAQCT (ORCPT ); Mon, 1 Oct 2012 12:02:19 -0400 MIME-Version: 1.0 In-Reply-To: <20121001080541.GM4009@amd.com> References: <1348835046-3262-1-git-send-email-joerg.roedel@amd.com> <1348835046-3262-13-git-send-email-joerg.roedel@amd.com> <20121001080541.GM4009@amd.com> Date: Mon, 1 Oct 2012 10:02:18 -0600 Message-ID: Subject: Re: [PATCH 12/16] iommu/amd: Add initialization routines for AMD interrupt remapping From: Shuah Khan To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 31 On Mon, Oct 1, 2012 at 2:05 AM, Joerg Roedel wrote: > On Fri, Sep 28, 2012 at 05:18:18PM -0600, Shuah Khan wrote: >> > +void amd_iommu_disable(void) >> > +{ >> > + amd_iommu_suspend(); >> >> Is it safe to attempt to suspend when iommu is in suspend state? In >> other words what happens if amd_iommu_disable() gets called when iommu >> is already in suspend state? > > Yes, this is safe. It just trns a bit to 0 which is already 0. > Good. >>> > +int amd_iommu_reenable(int mode) >> > +{ >> > + amd_iommu_resume(); >> >> Same question as above. Safe to do a resume, when in resumed state? > > Safe too, it just writes values to the hardware which are already there. > This was also proven by testing. > Thanks. Sounds good. -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/