Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124Ab2JBBUO (ORCPT ); Mon, 1 Oct 2012 21:20:14 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:52223 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350Ab2JBBTm (ORCPT ); Mon, 1 Oct 2012 21:19:42 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <506A4100.7070305@jp.fujitsu.com> Date: Tue, 2 Oct 2012 10:18:56 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: KOSAKI Motohiro CC: Ni zhan Chen , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC v9 PATCH 01/21] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages() References: <1346837155-534-1-git-send-email-wency@cn.fujitsu.com> <1346837155-534-2-git-send-email-wency@cn.fujitsu.com> <506509E4.1090000@gmail.com> <50651E68.3040208@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 50 Hi Kosaki-san, 2012/09/29 7:15, KOSAKI Motohiro wrote: > On Thu, Sep 27, 2012 at 11:50 PM, Yasuaki Ishimatsu > wrote: >> Hi Chen, >> >> >> 2012/09/28 11:22, Ni zhan Chen wrote: >>> >>> On 09/05/2012 05:25 PM, wency@cn.fujitsu.com wrote: >>>> >>>> From: Yasuaki Ishimatsu >>>> >>>> remove_memory() only try to offline pages. It is called in two cases: >>>> 1. hot remove a memory device >>>> 2. echo offline >/sys/devices/system/memory/memoryXX/state >>>> >>>> In the 1st case, we should also change memory block's state, and notify >>>> the userspace that the memory block's state is changed after offlining >>>> pages. >>>> >>>> So rename remove_memory() to offline_memory()/offline_pages(). And in >>>> the 1st case, offline_memory() will be used. The function >>>> offline_memory() >>>> is not implemented. In the 2nd case, offline_pages() will be used. >>> >>> >>> But this time there is not a function associated with add_memory. >> >> >> To associate with add_memory() later, we renamed it. > > Then, you introduced bisect breakage. It is definitely unacceptable. What is "bisect breakage" meaning? Thanks, Yasuaki Ishimatsu > > NAK. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/