Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240Ab2JBEey (ORCPT ); Tue, 2 Oct 2012 00:34:54 -0400 Received: from mail.active-venture.com ([67.228.131.205]:54130 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562Ab2JBEeX (ORCPT ); Tue, 2 Oct 2012 00:34:23 -0400 X-Originating-IP: 108.223.40.66 Date: Mon, 1 Oct 2012 21:35:00 -0700 From: Guenter Roeck To: Vivien Didelot Cc: lm-sensors@lm-sensors.org, Guillaume Roguez , Jean Delvare , linux-kernel@vger.kernel.org, Steve Hardy Subject: Re: [PATCH v2 2/2] hwmon: (ads7828) add support for ADS7830 Message-ID: <20121002043500.GA3247@roeck-us.net> References: <1349133384-5181-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1349133384-5181-2-git-send-email-vivien.didelot@savoirfairelinux.com> <20121002012007.GC2437@roeck-us.net> <1349148501.5876.22.camel@trivette> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349148501.5876.22.camel@trivette> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 31 On Mon, Oct 01, 2012 at 11:28:21PM -0400, Vivien Didelot wrote: > Hi Guenter, > Hi Vivien, [ ... ] > > > + } else { > > > + dev_dbg(&client->dev, "doesn't look like an " > > > + "ADS7828 compatible device\n"); > > > > WARNING: quoted string split across lines > > #190: FILE: drivers/hwmon/ads7828.c:196: > > + dev_dbg(&client->dev, "doesn't look like an " > > + "ADS7828 compatible device\n"); > Hum ok, so the reason for that is that it breaks the ability to grep a > string... Makes sense. > > > > Better: > > dev_dbg(&client->dev, > > "doesn't look like an ADS7828 compatible device\n"); > This exceeds 80 chars, but I'll find a shorter message. That is ok nowadays if it is due to a quoted string. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/