Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483Ab2JBMIL (ORCPT ); Tue, 2 Oct 2012 08:08:11 -0400 Received: from listserv2.niif.hu ([193.225.14.155]:54366 "EHLO listserv2.niif.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708Ab2JBMIJ (ORCPT ); Tue, 2 Oct 2012 08:08:09 -0400 From: Ferenc Wagner To: "Michael Chan" Cc: netdev@vger.kernel.org, "Matt Carlson" , "Grant Likely" , "Rob Herring" , linux-kernel@vger.kernel.org, wferi@niif.hu Subject: Re: tg3 driver upgrade (Linux 2.6.32 -> 3.2) breaks IBM Bladecenter SoL References: <87txuhho5z.fsf@lant.ki.iif.hu> <1349083982.5420.16.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> Date: Tue, 02 Oct 2012 14:07:57 +0200 In-Reply-To: <1349083982.5420.16.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> (Michael Chan's message of "Mon, 1 Oct 2012 02:33:02 -0700") Message-ID: <87a9w5dqle.fsf@lant.ki.iif.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1919 Lines: 48 "Michael Chan" writes: > On Fri, 2012-09-28 at 22:45 +0200, Ferenc Wagner wrote: > >> Upgrading the kernel on our HS20 blades resulted in their SoL (serial >> over LAN) connection being broken. The disconnection happens when eth0 >> (the interface involved in SoL) is brought up during the boot sequence. >> If I later "ip link set eth0 down", then the connection is restored, but >> "ip link set eth0 up" breaks it again on 3.2. ethtool -a, -c, -g, -k >> and -u show no difference; ethtool -i on the 2.6.32 kernel reports: >> >> driver: tg3 >> version: 3.116 >> firmware-version: 5704s-v3.38, ASFIPMIs v2.47 >> bus-info: 0000:05:01.0 >> >> In the 3.2 kernel the driver version is 3.121. > > 2.6.32 to 3.2 is a big jump. Can you narrow this down further? It will > be hard for us to find a HS20 with 5704 to test this. Thanks. I'm done with bisecting it: the first bad commit is: commit dabc5c670d3f86d15ee4f42ab38ec5bd2682487d Author: Matt Carlson Date: Thu May 19 12:12:52 2011 +0000 tg3: Move TSO_CAPABLE assignment This patch moves the code that asserts the TSO_CAPABLE flag closer to where the TSO capabilities flags are set. There isn't a good enough reason for the code to be separated. Signed-off-by: Matt Carlson Reviewed-by: Michael Chan Signed-off-by: David S. Miller On the other hand, losing the SoL console even temporarily during boot (as it happens with a minimal kernel before this commit) isn't nice either. I'll try to look after that, too, just mentioning it here... -- Regards, Feri. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/