Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755135Ab2JBQpd (ORCPT ); Tue, 2 Oct 2012 12:45:33 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:59994 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462Ab2JBQpa (ORCPT ); Tue, 2 Oct 2012 12:45:30 -0400 Message-ID: <506B1A26.2060609@pobox.com> Date: Tue, 02 Oct 2012 12:45:26 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Alexander Gordeev CC: Ingo Molnar , linux-kernel@vger.kernel.org, Thomas Gleixner , Bjorn Helgaas , Suresh Siddha , Yinghai Lu , Matthew Wilcox , x86@kernel.org, linux-pci@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs References: <20121002050929.GD7756@gmail.com> <20121002164220.GB2258@dhcp-26-207.brq.redhat.com> In-Reply-To: <20121002164220.GB2258@dhcp-26-207.brq.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 37 On 10/02/2012 12:42 PM, Alexander Gordeev wrote: > On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: >>> +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) >>> +{ >>> + struct ata_port *ap_this = dev_instance; >>> + struct ahci_port_priv *pp = ap_this->private_data; >>> + struct ata_host *host = ap_this->host; >>> + struct ahci_host_priv *hpriv = host->private_data; >>> + void __iomem *mmio = hpriv->mmio; >>> + unsigned int i; >>> + u32 irq_stat, irq_masked; >>> + >>> + VPRINTK("ENTER\n"); >> >> Is this per IRQ handler execution debugging code still needed? >> Same for the other VPRINTK() lines in this patch. > > These VPRINKs are only to make new handlers look like ahci_interrupt() > which did not change. I believe, if they need to go it is better to > remove them altogether, with a separate followup patch. Definitely followup patch material + discussion :) For the moment, the above is consistent with existing code, and by default compiled out, as one would expect. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/