MIME-Version: 1.0
In-Reply-To: <5060B9C2.5040200@cs.tu-berlin.de>
References: <20120823141422.444396696@google.com> <20120823141507.200772172@google.com>
 <5060B9C2.5040200@cs.tu-berlin.de>
From: Paul Turner <pjt@google.com>
Date: Tue, 2 Oct 2012 14:09:51 -0700
Message-ID: <CAPM31RKbmvMt0mYXfTNvQSO3WEowZ3=h1ayYFCBN=rMzGDu8bQ@mail.gmail.com>
Subject: Re: [patch 13/16] sched: update_cfs_shares at period edge
To: =?ISO-8859-1?Q?Jan_H=2E_Sch=F6nherr?= <schnhrr@cs.tu-berlin.de>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@elte.hu>,
        Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
        Srivatsa Vaddagiri <vatsa@in.ibm.com>,
        Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
        Venki Pallipadi <venki@google.com>, Ben Segall <bsegall@google.com>,
        Mike Galbraith <efault@gmx.de>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Namhyung Kim <namhyung@kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2088
Lines: 63

On Mon, Sep 24, 2012 at 12:51 PM, "Jan H. Sch?nherr"
<schnhrr@cs.tu-berlin.de> wrote:
> Am 23.08.2012 16:14, schrieb pjt@google.com:
>> From: Paul Turner <pjt@google.com>
>>
>> Now that our measurement intervals are small (~1ms) we can amortize the posting
>> of update_shares() to be about each period overflow.  This is a large cost
>> saving for frequently switching tasks.
>
> [snip]
>
>> @@ -1181,6 +1181,7 @@ static void update_cfs_rq_blocked_load(struct cfs_rq *cfs_rq, int force_update)
>>       }
>>
>>       __update_cfs_rq_tg_load_contrib(cfs_rq, force_update);
>> +     update_cfs_shares(cfs_rq);
>>  }
>
> Here a call to update_cfs_shares() gets added. Doesn't that make the call to
> update_cfs_shares() in __update_blocked_averages_cpu() superfluous?

Yes -- updated, Thanks.

>
>
> Function pasted here for reference:
>
> static void __update_blocked_averages_cpu(struct task_group *tg, int cpu)
> {
>         struct sched_entity *se = tg->se[cpu];
>         struct cfs_rq *cfs_rq = tg->cfs_rq[cpu];
>
>         /* throttled entities do not contribute to load */
>         if (throttled_hierarchy(cfs_rq))
>                 return;
>
>         update_cfs_rq_blocked_load(cfs_rq, 1);
>
>         if (se) {
>                 update_entity_load_avg(se, 1);
>                 /*
>                  * We can pivot on the runnable average decaying to zero for
>                  * list removal since the parent average will always be >=
>                  * child.
>                  */
>                 if (se->avg.runnable_avg_sum)
>                         update_cfs_shares(cfs_rq);
>                 else
>                         list_del_leaf_cfs_rq(cfs_rq);
>         } else {
>                 struct rq *rq = rq_of(cfs_rq);
>                 update_rq_runnable_avg(rq, rq->nr_running);
>         }
> }
>
>
> Regards
> Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/