Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932900Ab2JCASm (ORCPT ); Tue, 2 Oct 2012 20:18:42 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:48729 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932882Ab2JCASl (ORCPT ); Tue, 2 Oct 2012 20:18:41 -0400 MIME-Version: 1.0 In-Reply-To: <1349179923.13371.186.camel@smile> References: <1349178827-29643-1-git-send-email-yamanetoshi@gmail.com> <1349179923.13371.186.camel@smile> Date: Wed, 3 Oct 2012 09:18:39 +0900 Message-ID: Subject: Re: [PATCH 1/3] Fix trailing whitespace in trace.h From: Toshiaki Yamane To: Andy Shevchenko Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 39 On Tue, Oct 2, 2012 at 9:12 PM, Andy Shevchenko wrote: > On Tue, 2012-10-02 at 20:53 +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch error. >> >> -ERROR: trailing whitespace >> >> Signed-off-by: Toshiaki Yamane >> --- >> drivers/staging/rts_pstor/trace.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h >> index cf60a1b..740999c 100644 >> --- a/drivers/staging/rts_pstor/trace.h >> +++ b/drivers/staging/rts_pstor/trace.h >> @@ -39,7 +39,7 @@ static inline char *filename(char *path) >> while (*ptr != '\0') { >> if ((*ptr == '\\') || (*ptr == '/')) >> path = ptr + 1; >> - >> + >> ptr++; >> } > > For me it seems total filename() function could be squeezed to just strrchr(path, '/') + 1; > Moreover there is already basename() in the lib/dynamic_debug.c you > could rename, export and reuse. I will destroy this patch series. thanks. YAMANE Toshiaki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/