Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933114Ab2JCAb2 (ORCPT ); Tue, 2 Oct 2012 20:31:28 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:56380 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933093Ab2JCAas (ORCPT ); Tue, 2 Oct 2012 20:30:48 -0400 Message-ID: <506B8731.3020408@gmail.com> Date: Wed, 03 Oct 2012 10:30:41 +1000 From: Ryan Mallon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Andy Shevchenko CC: Andrew Morton , linux-kernel@vger.kernel.org, Joe Perches , YAMANE Toshiaki , Greg Kroah-Hartman Subject: Re: [PATCH 3/7] staging: rts_pstor: reuse kbasename() References: <1349190062-13107-1-git-send-email-andriy.shevchenko@linux.intel.com> <1349190062-13107-3-git-send-email-andriy.shevchenko@linux.intel.com> In-Reply-To: <1349190062-13107-3-git-send-email-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1696 Lines: 60 On 03/10/12 01:00, Andy Shevchenko wrote: > The custom filename function mostly repeats the kernel's kbasename. This patch > simplifies it. The updated filename() will not check for the '\' in the > filenames. It seems redundant in Linux. > > Signed-off-by: Andy Shevchenko > Cc: YAMANE Toshiaki > Cc: Greg Kroah-Hartman > --- > drivers/staging/rts_pstor/trace.h | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h > index cf60a1b..59c5686 100644 > --- a/drivers/staging/rts_pstor/trace.h > +++ b/drivers/staging/rts_pstor/trace.h > @@ -24,26 +24,16 @@ > #ifndef __REALTEK_RTSX_TRACE_H > #define __REALTEK_RTSX_TRACE_H > > +#include > + > #define _MSG_TRACE > > #ifdef _MSG_TRACE > static inline char *filename(char *path) > { > - char *ptr; > - > if (path == NULL) > return NULL; > - > - ptr = path; > - > - while (*ptr != '\0') { > - if ((*ptr == '\\') || (*ptr == '/')) > - path = ptr + 1; The original version here returns the string after the last '/' or '\', the new kbasename function only looks for '/'. Does that matter here, or was the original code over eager? ~Ryan > - > - ptr++; > - } > - > - return path; > + return kbasename(path); > } > > #define TRACE_RET(chip, ret) \ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/