Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603Ab2JCGtK (ORCPT ); Wed, 3 Oct 2012 02:49:10 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34754 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754646Ab2JCGtG (ORCPT ); Wed, 3 Oct 2012 02:49:06 -0400 Date: Tue, 2 Oct 2012 23:49:03 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Josh Triplett cc: Daniel Santos , LKML , Andi Kleen , Andrea Arcangeli , Andrew Morton , Christopher Li , David Daney , David Howells , Joe Perches , Konstantin Khlebnikov , linux-sparse@vger.kernel.org, Michel Lespinasse , Paul Gortmaker , Pavel Pisa , Peter Zijlstra , Steven Rostedt Subject: Re: [PATCH 7/10] compiler{,-gcc4}.h: Introduce __flatten function attribute In-Reply-To: <20120929005043.GD14293@jtriplet-mobl1> Message-ID: References: <1348874411-28288-1-git-send-email-daniel.santos@pobox.com> <1348874411-28288-8-git-send-email-daniel.santos@pobox.com> <20120929002626.GD13907@jtriplet-mobl1> <50664308.6020601@att.net> <20120929005043.GD14293@jtriplet-mobl1> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 17 On Fri, 28 Sep 2012, Josh Triplett wrote: > That issue doesn't relate to __flatten, though; it only relates to > __weak. Since __flatten (and __compiletime_object_size) will work fine > on 4.1.0 and 4.1.1, don't exclude them just because the definition for > __weak elsewhere in the file excludes them. That just makes it harder > for anyone who might want to work on the issue with __weak. > Nack to the patch since there are no users of it; there's no need to define every possible gcc function attribute. If anything actually needs to use __attribute__((flatten)), then it can introduce it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/