Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753779Ab2JCLr1 (ORCPT ); Wed, 3 Oct 2012 07:47:27 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:41709 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473Ab2JCLr0 (ORCPT ); Wed, 3 Oct 2012 07:47:26 -0400 Date: Wed, 3 Oct 2012 07:47:21 -0400 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: Christoph Hellwig , target-devel , linux-scsi , linux-kernel , Mike Christie , Hannes Reinecke , Roland Dreier , Andy Grover , Christoph Hellwig , stable@vger.kernel.org Subject: Re: [PATCH 1/6] target/file: Re-enable optional fd_buffered_io=1 operation Message-ID: <20121003114721.GA16209@infradead.org> References: <1348984696-30992-1-git-send-email-nab@linux-iscsi.org> <1348984696-30992-2-git-send-email-nab@linux-iscsi.org> <20121001084605.GA23497@infradead.org> <1349209004.28145.61.camel@haakon2.linux-iscsi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349209004.28145.61.camel@haakon2.linux-iscsi.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 19 On Tue, Oct 02, 2012 at 01:16:44PM -0700, Nicholas A. Bellinger wrote: > * Optionally allow fd_buffered_io=1 to be enabled for people > * who want use the fs buffer cache as an WriteCache mechanism. > * > * This means that in event of a hard failure, there is a risk > * of silent data-loss if the SCSI client has *not* performed a > * forced unit access (FUA) write, or issued SYNCHRONIZE_CACHE > * to write-out the entire device cache. > */ Oh, I get Vlads flame. This doesn't simply disable O_DSYNC now but also sets WCE=1. In this case I don't really get the point of the patch, why can't we simply set it from configfs? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/