Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932549Ab2JCO5r (ORCPT ); Wed, 3 Oct 2012 10:57:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932354Ab2JCO5o (ORCPT ); Wed, 3 Oct 2012 10:57:44 -0400 Message-ID: <506C5239.4080209@redhat.com> Date: Wed, 03 Oct 2012 16:56:57 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Raghavendra K T CC: Gleb Natapov , Jiannan Ouyang , Peter Zijlstra , Rik van Riel , "H. Peter Anvin" , Ingo Molnar , Marcelo Tosatti , Srikar , "Nikunj A. Dadhania" , KVM , chegu vinod , "Andrew M. Theurer" , LKML , Srivatsa Vaddagiri Subject: Re: [PATCH RFC 1/2] kvm: Handle undercommitted guest case in PLE handler References: <5060851E.1030404@redhat.com> <506166B4.4010207@linux.vnet.ibm.com> <5061713D.5060406@redhat.com> <50641356.5070008@redhat.com> <506540C7.9070105@linux.vnet.ibm.com> <50680049.5020206@redhat.com> <20120930110755.GB1009@redhat.com> <50682945.3060309@redhat.com> <20121003141739.GA15253@linux.vnet.ibm.com> In-Reply-To: <20121003141739.GA15253@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 46 On 10/03/2012 04:17 PM, Raghavendra K T wrote: > * Avi Kivity [2012-09-30 13:13:09]: > >> On 09/30/2012 01:07 PM, Gleb Natapov wrote: >> > On Sun, Sep 30, 2012 at 10:18:17AM +0200, Avi Kivity wrote: >> >> On 09/28/2012 08:16 AM, Raghavendra K T wrote: >> >> > >> >> >> >> >> >> +struct pv_sched_info { >> >> >> + unsigned long sched_bitmap; >> >> > >> >> > Thinking, whether we need something similar to cpumask here? >> >> > Only thing is we are representing guest (v)cpumask. >> >> > >> >> >> >> DECLARE_BITMAP(sched_bitmap, KVM_MAX_VCPUS) >> >> >> > vcpu_id can be greater than KVM_MAX_VCPUS. >> >> Use the index into the vcpu table as the bitmap index then. In fact >> it's better because then the lookup to get the vcpu pointer is trivial. > > Did you mean, while setting the bitmap, > > we should do > for (i = 1..n) > if (kvm->vcpus[i] == vcpu) set ith position in bitmap? You can store i in the vcpu itself: set_bit(vcpu->index, &kvm->preempted); > > I just wanted to know whether there is any easy way to convert from > vcpu pointer to index in kvm vcpu table. > -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/