Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932917Ab2JCQsD (ORCPT ); Wed, 3 Oct 2012 12:48:03 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51476 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932851Ab2JCQr7 (ORCPT ); Wed, 3 Oct 2012 12:47:59 -0400 Date: Wed, 3 Oct 2012 12:47:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Florian Fainelli cc: linux-usb@vger.kernel.org, Ralf Baechle , Jayachandran C , , Subject: Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver In-Reply-To: <1349276601-8371-5-git-send-email-florian@openwrt.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2021 Lines: 59 On Wed, 3 Oct 2012, Florian Fainelli wrote: > Signed-off-by: Florian Fainelli IMO, patches should always have a non-empty changelog. Even if it is relatively trivial. The same comment applies to several other patches in this series. > --- > arch/mips/netlogic/xlr/platform.c | 6 ++++++ > 1 file changed, 6 insertions(+) Does this need to enable CONFIG_USB_EHCI_HCD_PLATFORM is some defconfig file, like you did with the MIPS Loongson 1B? And likewise for quite a few of the other patches in this series. > diff --git a/arch/mips/netlogic/xlr/platform.c b/arch/mips/netlogic/xlr/platform.c > index 71b44d8..1731dfd 100644 > --- a/arch/mips/netlogic/xlr/platform.c > +++ b/arch/mips/netlogic/xlr/platform.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -123,6 +124,10 @@ static u64 xls_usb_dmamask = ~(u32)0; > }, \ > } > > +static struct usb_ehci_pdata xls_usb_ehci_pdata = { > + .caps_offset = 0, > +}; > + > static struct platform_device xls_usb_ehci_device = > USB_PLATFORM_DEV("ehci-xls", 0, PIC_USB_IRQ); > static struct platform_device xls_usb_ohci_device_0 = > @@ -172,6 +177,7 @@ int xls_platform_usb_init(void) > memres = CPHYSADDR((unsigned long)usb_mmio); > xls_usb_ehci_device.resource[0].start = memres; > xls_usb_ehci_device.resource[0].end = memres + 0x400 - 1; > + xls_usb_ehci_device.dev.platform_data = &xls_usb_ehci_pdata; > > memres += 0x400; > xls_usb_ohci_device_0.resource[0].start = memres; Don't you need to change/set the pdev name also? Likewise for patch 20/25 and 24/25. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/