Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016Ab2JCUad (ORCPT ); Wed, 3 Oct 2012 16:30:33 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:48770 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452Ab2JCUab (ORCPT ); Wed, 3 Oct 2012 16:30:31 -0400 Date: Wed, 3 Oct 2012 13:29:29 -0700 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: LKML , Josh Triplett , Peter Zijlstra Subject: Re: [PATCH] rcu: Remove rcu_switch() Message-ID: <20121003202929.GU2527@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1349288512-2635-1-git-send-email-fweisbec@gmail.com> <20121003183945.GP2527@linux.vnet.ibm.com> <20121003200533.GC637@somewhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121003200533.GC637@somewhere> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12100320-7408-0000-0000-0000090123F9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2126 Lines: 54 On Wed, Oct 03, 2012 at 10:05:43PM +0200, Frederic Weisbecker wrote: > On Wed, Oct 03, 2012 at 11:39:45AM -0700, Paul E. McKenney wrote: > > On Wed, Oct 03, 2012 at 08:21:52PM +0200, Frederic Weisbecker wrote: > > > It's only there to call rcu_user_hooks_switch(). Let's > > > just call rcu_user_hooks_switch() directly, we don't need this > > > function in the middle. > > > > Hello, Frederic! > > > > Doesn't this also require an empty definition of rcu_user_hooks_switch() > > to handle the CONFIG_RCU_USER_QS=n case? Or is there already such > > a definition that I am too blind to see? > > There is, look below: Right you are! Queued. Thanx, Paul > > > Signed-off-by: Frederic Weisbecker > > > Cc: Josh Triplett > > > Cc: Peter Zijlstra > > > --- > > > include/linux/rcupdate.h | 2 ++ > > > include/linux/sched.h | 8 -------- > > > kernel/sched/core.c | 2 +- > > > 3 files changed, 3 insertions(+), 9 deletions(-) > > > > > > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h > > > index 7c968e4..5d009de 100644 > > > --- a/include/linux/rcupdate.h > > > +++ b/include/linux/rcupdate.h > > > @@ -204,6 +204,8 @@ static inline void rcu_user_enter(void) { } > > > static inline void rcu_user_exit(void) { } > > > static inline void rcu_user_enter_after_irq(void) { } > > > static inline void rcu_user_exit_after_irq(void) { } > > > +static inline void rcu_user_hooks_switch(struct task_struct *prev, > > > + struct task_struct *next) { } > > Here. > > > > #endif /* CONFIG_RCU_USER_QS */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/