Subject: Re: [PATCH 1/6] target/file: Re-enable optional fd_buffered_io=1
 operation
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: target-devel <target-devel@vger.kernel.org>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Christie <michaelc@cs.wisc.edu>, Hannes Reinecke <hare@suse.de>,
        Roland Dreier <roland@purestorage.com>,
        Andy Grover <agrover@redhat.com>, Christoph Hellwig <hch@lst.de>,
        stable@vger.kernel.org
In-Reply-To: <20121003114721.GA16209@infradead.org>
References: <1348984696-30992-1-git-send-email-nab@linux-iscsi.org>
	 <1348984696-30992-2-git-send-email-nab@linux-iscsi.org>
	 <20121001084605.GA23497@infradead.org>
	 <1349209004.28145.61.camel@haakon2.linux-iscsi.org>
	 <20121003114721.GA16209@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 03 Oct 2012 17:02:35 -0700
Message-ID: <1349308955.28145.183.camel@haakon2.linux-iscsi.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1491
Lines: 32

On Wed, 2012-10-03 at 07:47 -0400, Christoph Hellwig wrote:
> On Tue, Oct 02, 2012 at 01:16:44PM -0700, Nicholas A. Bellinger wrote:
> >          * Optionally allow fd_buffered_io=1 to be enabled for people
> >          * who want use the fs buffer cache as an WriteCache mechanism.
> >          *
> >          * This means that in event of a hard failure, there is a risk
> >          * of silent data-loss if the SCSI client has *not* performed a
> >          * forced unit access (FUA) write, or issued SYNCHRONIZE_CACHE
> >          * to write-out the entire device cache.
> >          */
> 
> Oh, I get Vlads flame.  This doesn't simply disable O_DSYNC now but also
> sets WCE=1.  In this case I don't really get the point of the patch, why
> can't we simply set it from configfs?
> 

The patch prevents existing user-space code from using fd_buffered_io=1
operation incorrectly regardless of what is being set for
emulate_write_cache device attribute.

Using FILEIO w/o O_DSYNC + emulate_write_cache=0 is certainly a big
no-no regardless of context, so I'd rather enforce the right thing to do
here from kernel code for this special case instead of allowing an
unsafe mode to be enabled by default + set attributes from user-space.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/