Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755671Ab2JDFwt (ORCPT ); Thu, 4 Oct 2012 01:52:49 -0400 Received: from tw-mx2.synaptics.com.tw ([203.163.83.68]:7099 "EHLO tw-mx2.synaptics.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753833Ab2JDFwr convert rfc822-to-8bit (ORCPT ); Thu, 4 Oct 2012 01:52:47 -0400 From: Alexandra Chin To: Henrik Rydberg CC: Dmitry Torokhov , Linux Kernel , Linux Input , Linus Walleij , Naveen Kumar Gaddipati , Mahesh Srinivasan , Alex Chang , Scott Lin , Christopher Heiny Subject: RE: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices Thread-Topic: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices Thread-Index: AQHNk/HhVA088HpSAk6VMBpKXya6/ZelpTiwgAFjI8CAAGvVgIABSqoA Date: Thu, 4 Oct 2012 05:52:45 +0000 Message-ID: References: <20121003180121.GA4198@polaris.bitmath.org> In-Reply-To: <20121003180121.GA4198@polaris.bitmath.org> Accept-Language: zh-TW, en-US Content-Language: zh-HK X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.14.51.94] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 36 From: Henrik Rydberg Sent: Thursday, October 04, 2012 2:01 AM > It seems this driver is already present in staging. Comments and > formatting have been improved in the staging version, but that aside, > the two versions look very similar. Why don't you submit fixes to > that driver instead? > On a general note, both versions of the driver use MT-A. Please > convert to MT-B, using the in-kernel tracking if necessary. Hi Henrik, Appreciate your suggestion! We are going to update a patch of using MT-B, because Synaptics devices are capable of tracking identifiable contacts (type B). Thanks for pointing out this. You are right, there is already a synaptics_i2c_rmi4 driver in staging state (drivers/staging/ste_rmi4). Actually synaptics_ds4_i2c driver is developed based on synaptics_i2c_rmi4 driver. The point is that we would want to make a clear definition that synaptics_ds4_i2c only targets to DS4 family, so that we can keep maintaining driver focusing on DS4 product line (not all Synaptics touchscreen devices are DS4 compatible). We are open to discuss if it is appropriate to retained DS4 driver, and please let us know if you have any concerns. Best Regards, Alexandra Chin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/