Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318Ab2JDGvp (ORCPT ); Thu, 4 Oct 2012 02:51:45 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:45809 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694Ab2JDGvm (ORCPT ); Thu, 4 Oct 2012 02:51:42 -0400 Date: Wed, 3 Oct 2012 23:51:37 -0700 From: Dmitry Torokhov To: Alexandra Chin Cc: Henrik Rydberg , Linux Kernel , Linux Input , Linus Walleij , Naveen Kumar Gaddipati , Mahesh Srinivasan , Alex Chang , Scott Lin , Christopher Heiny Subject: Re: [PATCH] Input: Add new driver into Input Subsystem for Synaptics DS4 touchscreen I2C devices Message-ID: <20121004065137.GA14217@core.coreip.homeip.net> References: <20121003180121.GA4198@polaris.bitmath.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 45 Hi Alexandra, On Thu, Oct 04, 2012 at 05:52:45AM +0000, Alexandra Chin wrote: > From: Henrik Rydberg > Sent: Thursday, October 04, 2012 2:01 AM > > It seems this driver is already present in staging. Comments and > > formatting have been improved in the staging version, but that aside, > > the two versions look very similar. Why don't you submit fixes to > > that driver instead? > > > On a general note, both versions of the driver use MT-A. Please > > convert to MT-B, using the in-kernel tracking if necessary. > > > Hi Henrik, > > Appreciate your suggestion! > We are going to update a patch of using MT-B, because Synaptics devices are > capable of tracking identifiable contacts (type B). > Thanks for pointing out this. > > You are right, there is already a synaptics_i2c_rmi4 driver in staging > state (drivers/staging/ste_rmi4). > Actually synaptics_ds4_i2c driver is developed based on synaptics_i2c_rmi4 > driver. The point is that we would want to make a clear definition that > synaptics_ds4_i2c only targets to DS4 family, so that we can keep maintaining > driver focusing on DS4 product line (not all Synaptics touchscreen devices are > DS4 compatible). Given that the other group at Synaptics works on general version of RMI4 driver what is the benefit of having separate driver for DS4 line? I can understand keeping one copy of older driver in staging so that some customers coudl still use hardware while universal implementation is being developed, but I do not see why we would want to have 3 separate drivers. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/