Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932185Ab2JDHkN (ORCPT ); Thu, 4 Oct 2012 03:40:13 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:55370 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461Ab2JDHkJ (ORCPT ); Thu, 4 Oct 2012 03:40:09 -0400 Date: Thu, 4 Oct 2012 09:40:04 +0200 From: Jiri Pirko To: Mirko Lindner Cc: Stephen Hemminger , "netdev@vger.kernel.org" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" Subject: Re: [patch net] sky2: fix rx filter setup on link up Message-ID: <20121004074004.GA6620@minipsycho.orion> References: <1347894617-13614-1-git-send-email-jiri@resnulli.us> <20120917091214.5cd9b0f5@nehalam.linuxnetplumber.net> <20120917204724.GA1749@minipsycho.orion> <175CCF5F49938B4D99B2E3EF7F558EBE1B63898F0B@SC-VEXCH4.marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <175CCF5F49938B4D99B2E3EF7F558EBE1B63898F0B@SC-VEXCH4.marvell.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 30 Tue, Sep 18, 2012 at 02:38:52AM CEST, mlindner@marvell.com wrote: >>Mon, Sep 17, 2012 at 06:12:14PM CEST, shemminger@vyatta.com wrote: >>>On Mon, 17 Sep 2012 17:10:17 +0200 >>>Jiri Pirko wrote: >>> >>>> In my case I have following problem. sky2_set_multicast() sets registers >>>> GM_MC_ADDR_H[1-4] correctly to: >>>> 0000 0800 0001 0410 >>>> However, when adapter gets link and sky2_link_up() is called, the values >>>> are for some reason different: >>>> 0000 0800 0016 0410 >>> >>>Rather than papering over the problem, it would be better to >>>trace back what is setting those registers and fix that code. > >>Yes, I did that. No code at sky2.[ch] is writing to this registers other >>than sky2_set_multicast() and sky2_gmac_reset() (I hooked on sky2_write*()). >>So I strongly believe this is a HW issue (maybe only issue of my revision >>"Yukon-2 EC chip revision 2") > >I would like to check the registers as soon as I'm back in my office next week and report my findings. >Could you also please check the hint from Stephen? Mirko, did you have a chance to look at this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/