Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754997Ab2JDJ1F (ORCPT ); Thu, 4 Oct 2012 05:27:05 -0400 Received: from twin.jikos.cz ([89.185.236.188]:60060 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936Ab2JDJ1D (ORCPT ); Thu, 4 Oct 2012 05:27:03 -0400 Date: Thu, 4 Oct 2012 11:26:44 +0200 From: David Sterba To: Rock Lee Cc: chris.mason@fusionio.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs ulist use rbtree instead Message-ID: <20121004092644.GB14582@twin.jikos.cz> Reply-To: dave@jikos.cz Mail-Followup-To: Rock Lee , chris.mason@fusionio.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1349341866-29320-1-git-send-email-zimilo@code-trick.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349341866-29320-1-git-send-email-zimilo@code-trick.com> User-Agent: Mutt/1.5.21 (2011-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 21 > @@ -207,16 +266,23 @@ EXPORT_SYMBOL(ulist_add); > * end is reached. No guarantee is made with respect to the order in which > * the elements are returned. They might neither be returned in order of > * addition nor in ascending order. > - * It is allowed to call ulist_add during an enumeration. Newly added items > - * are guaranteed to show up in the running enumeration. > */ > struct ulist_node *ulist_next(struct ulist *ulist, struct ulist_iterator *uiter) Quick observation: If there's code relying on the behaviour stated in the removed part of the comment, it will break. Have you verified this is not the case? david -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/