Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886Ab2JDJsp (ORCPT ); Thu, 4 Oct 2012 05:48:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55718 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153Ab2JDJsn (ORCPT ); Thu, 4 Oct 2012 05:48:43 -0400 Date: Thu, 4 Oct 2012 11:48:31 +0200 (CEST) From: Jiri Kosina To: Benjamin Tissoires Cc: Dmitry Torokhov , Stephane Chatty , fabien.andre@gmail.com, scott.liu@emc.com.tw, Jean Delvare , Ben Dooks , Wolfram Sang , linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation In-Reply-To: Message-ID: References: <1347630103-4105-1-git-send-email-benjamin.tissoires@gmail.com> <20121003164306.GA18529@core.coreip.homeip.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 24 On Thu, 4 Oct 2012, Benjamin Tissoires wrote: > >> + > >> + hid->claimed = 0; > > > > Should it be here and not in core? > > This is a line that was copied/pasted from usbhid. I'll check how can > I do that without interfering with core. Well, we are calling ll_driver->stop at multiple places, so having this reset in the actual ll driver callback seems to be cleaner. (if I understand the concern here correctly). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/